Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid unnecessary reloads generating lua_shared_dict directives #4587

Merged
merged 1 commit into from
Sep 23, 2019

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Sep 23, 2019

What this PR does / why we need it:

Running the controller with --v=2 the lua_shared_dict order changes and forces a reload

-	lua_shared_dict configuration_data 20M;
-	lua_shared_dict certificate_data 20M;
-	lua_shared_dict balancer_ewma 10M;
 	lua_shared_dict balancer_ewma_last_touched_at 10M;
 	lua_shared_dict balancer_ewma_locks 1M;
 	lua_shared_dict certificate_servers 5M;
+	lua_shared_dict configuration_data 20M;
+	lua_shared_dict certificate_data 20M;
+	lua_shared_dict balancer_ewma 10M;

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 23, 2019
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 23, 2019
@aledbf
Copy link
Member Author

aledbf commented Sep 23, 2019

/retest

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@624ce08). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4587   +/-   ##
=========================================
  Coverage          ?   58.54%           
=========================================
  Files             ?       88           
  Lines             ?     6691           
  Branches          ?        0           
=========================================
  Hits              ?     3917           
  Misses            ?     2339           
  Partials          ?      435
Impacted Files Coverage Δ
internal/ingress/controller/template/template.go 78.93% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 624ce08...1b8f651. Read the comment docs.

@ElvinEfendi
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 23, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, ElvinEfendi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 9b66f2a into kubernetes:master Sep 23, 2019
@aledbf aledbf deleted the order-directives branch September 23, 2019 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants