optimize: local cache global variable and avoid single lines over 80

[membphis]

if this commit is fine, I'll submit more later.

[k8s-ci-robot]

Welcome @membphis!

It looks like this is your first PR to kubernetes/ingress-nginx 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/ingress-nginx has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
• Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: login-issues@jira.linuxfoundation.org

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[k8s-ci-robot]

Hi @membphis. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[ElvinEfendi]

/ok-to-test

[codecov-io]

Codecov Report

❗ No coverage uploaded for pull request base (master@f6c2f5f). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #4591   +/-   ##
=========================================
  Coverage          ?   58.53%           
=========================================
  Files             ?       88           
  Lines             ?     6699           
  Branches          ?        0           
=========================================
  Hits              ?     3921           
  Misses            ?     2341           
  Partials          ?      437

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6c2f5f...1ce68c8. Read the comment docs.

[ElvinEfendi]

This will require us to adjust some unit tests as they mock some ngx APIs before loading the modules: https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/ingress-nginx/4591/pull-ingress-nginx-test-lua/1176327555209236481

[ElvinEfendi]

if this commit is fine, I'll submit more later.

@membphis thanks for the PR! Such PRs are always welcome.

I'm thinking of adding linter to force these best practices.

[membphis]

it's not easy to do these local cache optimize, all of the test case was run in standard Lua which is very different for openresty or nginx+lua, that is why we have to mock something before run test cases.

the new code should be fine under openresty or nginx+lua.

Do we have any plan to run those test case in openresty or nginx+lua?

[ElvinEfendi]

@membphis we use resty to run the Lua tests. All the tests run in timer phase.

We already have e2e tests for the type of test you are describing. These Lua tests are unit tests.

[membphis]

@ElvinEfendi Thanks for your explanation, we run the test case with resty command.

I'll continue to fix it.

[aledbf]

@membphis you can run the test locally executing the command ./build/run-in-docker.sh make lua-test

[aledbf]

@membphis also, please squash the commits

[ElvinEfendi]

please delete instead of leaving commented

[membphis]

@membphis you can run the test locally executing the command ./build/run-in-docker.sh make lua-test

thanks for this, I do not know this before :(

[membphis]

@aledbf all fixed, please take a look.

[ElvinEfendi]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ElvinEfendi, membphis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ElvinEfendi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment