-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor force ssl redirect logic #4592
refactor force ssl redirect logic #4592
Conversation
end | ||
|
||
return get_pem_cert_key(hostname) ~= nil | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aledbf this function is the crucial bit here, it is to replace server.SSLCert != nil
. Please pay special attention to make sure we aren't introducing a regression.
Codecov Report
@@ Coverage Diff @@
## master #4592 +/- ##
=========================================
Coverage ? 58.64%
=========================================
Files ? 88
Lines ? 6736
Branches ? 0
=========================================
Hits ? 3950
Misses ? 2350
Partials ? 436
Continue to review full report at Codecov.
|
This PR requires #4594. |
/test pull-ingress-nginx-test |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, ElvinEfendi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Addressing part of #4356 (comment)
The idea is to move dependency on certificate existence to the Lua module so that we don't regenerate Nginx configuration when secret/certificate is added or deleted for the server.
What this PR does / why we need it:
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #Special notes for your reviewer: