Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor force ssl redirect logic #4592

Merged
merged 1 commit into from
Sep 24, 2019
Merged

refactor force ssl redirect logic #4592

merged 1 commit into from
Sep 24, 2019

Conversation

ElvinEfendi
Copy link
Member

Addressing part of #4356 (comment)

The idea is to move dependency on certificate existence to the Lua module so that we don't regenerate Nginx configuration when secret/certificate is added or deleted for the server.

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 24, 2019
end

return get_pem_cert_key(hostname) ~= nil
end
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aledbf this function is the crucial bit here, it is to replace server.SSLCert != nil. Please pay special attention to make sure we aren't introducing a regression.

@codecov-io
Copy link

codecov-io commented Sep 24, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@73bc2cf). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4592   +/-   ##
=========================================
  Coverage          ?   58.64%           
=========================================
  Files             ?       88           
  Lines             ?     6736           
  Branches          ?        0           
=========================================
  Hits              ?     3950           
  Misses            ?     2350           
  Partials          ?      436
Impacted Files Coverage Δ
internal/ingress/controller/template/template.go 79.63% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73bc2cf...8c64b12. Read the comment docs.

@ElvinEfendi
Copy link
Member Author

This PR requires #4594.

@ElvinEfendi
Copy link
Member Author

/test pull-ingress-nginx-test

@ElvinEfendi ElvinEfendi changed the title [WIP] refactor force ssl redirect logic refactor force ssl redirect logic Sep 24, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 24, 2019
@aledbf
Copy link
Member

aledbf commented Sep 24, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 24, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, ElvinEfendi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 56edbb9 into kubernetes:master Sep 24, 2019
@ElvinEfendi ElvinEfendi deleted the force-ssl-redirect-refactoring branch September 24, 2019 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants