-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sort auth proxy headers from configmap #4596
sort auth proxy headers from configmap #4596
Conversation
/lgtm |
@ElvinEfendi is a map, not a list, you need to create an array with the keys, sort that and iterate the sorted list |
e6e52d1
to
d124dd5
Compare
Codecov Report
@@ Coverage Diff @@
## master #4596 +/- ##
==========================================
+ Coverage 58.58% 59.88% +1.29%
==========================================
Files 88 88
Lines 6735 7008 +273
==========================================
+ Hits 3946 4197 +251
- Misses 2352 2360 +8
- Partials 437 451 +14
Continue to review full report at Codecov.
|
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, ElvinEfendi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Fixing flaky order dependent test introduced in #4550:
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #Special notes for your reviewer: