-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose GeoIP2 Organization as variable $geoip2_org #4650
Conversation
Welcome @DaveAurionix! |
Hi @DaveAurionix. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @ElvinEfendi |
/lgtm |
@DaveAurionix please don't assign PRs manually. Thanks |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, DaveAurionix The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
Codecov Report
@@ Coverage Diff @@
## master #4650 +/- ##
==========================================
+ Coverage 58.67% 58.69% +0.01%
==========================================
Files 88 88
Lines 6764 6766 +2
==========================================
+ Hits 3969 3971 +2
Misses 2356 2356
Partials 439 439
Continue to review full report at Codecov.
|
@aledbf I'm sorry. The messages from the bots on this channel might need reviewing - new users get an email telling them to follow all instructions from the bots when prompted, then another email saying that "To complete the pull request process, please assign . You can assign the PR to them by writing ..." (followed by a bot command that I've omitted). It's not clear that we're not supposed to follow that. I'll have a look at the failing tests, thanks for triggering them. |
@aledbf The above tests seemed to have all (Edited...) Sorry I've just noticed the PR is approved anyway. I'll assume there is nothing else I need to do unless I hear from you otherwise. Thanks for your time on this. |
/retest |
What this PR does / why we need it: Add support for logging the client IP's organization from GeoIP2 database. Mirrors existing $geoip_org that is populated from the now-deprecated GeoIP database.
Which issue this PR fixes: not a big enough problem to raise an issue?
Special notes for your reviewer: