Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose GeoIP2 Organization as variable $geoip2_org #4650

Merged
merged 1 commit into from
Oct 12, 2019
Merged

Expose GeoIP2 Organization as variable $geoip2_org #4650

merged 1 commit into from
Oct 12, 2019

Conversation

DaveAurionix
Copy link
Contributor

What this PR does / why we need it: Add support for logging the client IP's organization from GeoIP2 database. Mirrors existing $geoip_org that is populated from the now-deprecated GeoIP database.

Which issue this PR fixes: not a big enough problem to raise an issue?

Special notes for your reviewer:

@k8s-ci-robot
Copy link
Contributor

Welcome @DaveAurionix!

It looks like this is your first PR to kubernetes/ingress-nginx 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/ingress-nginx has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 9, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @DaveAurionix. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 9, 2019
@DaveAurionix
Copy link
Contributor Author

/assign @ElvinEfendi

@aledbf
Copy link
Member

aledbf commented Oct 12, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 12, 2019
@aledbf
Copy link
Member

aledbf commented Oct 12, 2019

@DaveAurionix please don't assign PRs manually. Thanks

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, DaveAurionix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 12, 2019
@aledbf
Copy link
Member

aledbf commented Oct 12, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 12, 2019
@codecov-io
Copy link

codecov-io commented Oct 12, 2019

Codecov Report

Merging #4650 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4650      +/-   ##
==========================================
+ Coverage   58.67%   58.69%   +0.01%     
==========================================
  Files          88       88              
  Lines        6764     6766       +2     
==========================================
+ Hits         3969     3971       +2     
  Misses       2356     2356              
  Partials      439      439
Impacted Files Coverage Δ
...nternal/ingress/controller/template/buffer_pool.go 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fd1704...8e926b2. Read the comment docs.

@DaveAurionix
Copy link
Contributor Author

@aledbf I'm sorry. The messages from the bots on this channel might need reviewing - new users get an email telling them to follow all instructions from the bots when prompted, then another email saying that "To complete the pull request process, please assign . You can assign the PR to them by writing ..." (followed by a bot command that I've omitted). It's not clear that we're not supposed to follow that.

I'll have a look at the failing tests, thanks for triggering them.

@DaveAurionix
Copy link
Contributor Author

DaveAurionix commented Oct 12, 2019

@aledbf The above tests seemed to have all failed to wait for endpoints to become ready. I'm not yet sure a one-line PR can have caused all of those tests to fail with that same reason, shall I follow the bot instruction to retest?

(Edited...) Sorry I've just noticed the PR is approved anyway. I'll assume there is nothing else I need to do unless I hear from you otherwise. Thanks for your time on this.

@aledbf
Copy link
Member

aledbf commented Oct 12, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit 69880ac into kubernetes:master Oct 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants