Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase the kubernetes 1.14 version to the installation prompt #4678

Merged
merged 1 commit into from
Oct 15, 2019
Merged

Increase the kubernetes 1.14 version to the installation prompt #4678

merged 1 commit into from
Oct 15, 2019

Conversation

wawa0210
Copy link
Contributor

What this PR does / why we need it:

Added installation instructions for the kubernetes cluster before version 1.14

#4645

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 14, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @wawa0210. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 14, 2019
@wawa0210
Copy link
Contributor Author

@aledbf Can you review this pr

@aledbf
Copy link
Member

aledbf commented Oct 14, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 14, 2019
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@decc134). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4678   +/-   ##
=========================================
  Coverage          ?   58.66%           
=========================================
  Files             ?       88           
  Lines             ?     6762           
  Branches          ?        0           
=========================================
  Hits              ?     3967           
  Misses            ?     2356           
  Partials          ?      439

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update decc134...13a9edd. Read the comment docs.

aledbf
aledbf reviewed Oct 14, 2019
View reviewed changes
docs/deploy/index.md Outdated
@@ -37,6 +37,9 @@ The following **Mandatory Command** is required for all deployments.
kubectl apply -f https://raw.githubusercontent.com/kubernetes/ingress-nginx/master/deploy/static/mandatory.yaml
```

!!! tip
If your kubernetes version is less than 1.14, you will need to change `kubernetes.io/os` to `beta.kubernetes.io/os`, see [Labels details](https://kubernetes.io/docs/reference/kubernetes-api/labels-annotations-taints/).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe If you are using a Kubernetes version previous to 1.14, you need to change...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, point to the line in mandatory.yaml

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done .

@aledbf
Copy link
Member

aledbf commented Oct 15, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 15, 2019
@aledbf
Copy link
Member

aledbf commented Oct 15, 2019

@wawa0210 thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, wawa0210

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 15, 2019
@k8s-ci-robot k8s-ci-robot merged commit 04e2ad8 into kubernetes:master Oct 15, 2019
@aledbf aledbf mentioned this pull request Oct 15, 2019
Closed
@wawa0210 wawa0210 deleted the doc-install-update branch October 15, 2019 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aledbf aledbf aledbf left review comments

@ElvinEfendi ElvinEfendi Awaiting requested review from ElvinEfendi

Assignees

@aledbf aledbf

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wawa0210 @k8s-ci-robot @aledbf @codecov-io