-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement : add remote_addr in TCP access log #4694
Enhancement : add remote_addr in TCP access log #4694
Conversation
original: [18/Oct/2019:00:47:53 +0000] TCP 200 4333 81 0.002 new: [10.6.124.202] [18/Oct/2019:01:05:15 +0000] TCP 200 4333 81 0.002
Welcome @panpan0000! |
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Hi @panpan0000. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
CLA is signed . @k8s-ci-robot |
/assign @bowei |
/ok-to-test |
Please update the documentation about the format too https://kubernetes.github.io/ingress-nginx/user-guide/nginx-configuration/configmap/#log-format-stream |
Codecov Report
@@ Coverage Diff @@
## master #4694 +/- ##
=========================================
Coverage ? 58.68%
=========================================
Files ? 88
Lines ? 6762
Branches ? 0
=========================================
Hits ? 3968
Misses ? 2357
Partials ? 437 Continue to review full report at Codecov.
|
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, panpan0000 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thank you for your reminder, @aledbf . (1) I've add this change in (2) regarding the Live doc (https://kubernetes.github.io/ingress-nginx/user-guide/nginx-configuration/configmap/#log-format-stream), the original live doc is only about "HTTP log-format". The "TCP log-format" is not mentioned although, so I cannot fit my change into that doc :-( |
What this PR does / why we need it:
because source IP is essential for access log , not only for http logs ,but also for TCP logs.
original:
[18/Oct/2019:00:47:53 +0000] TCP 200 4333 81 0.002
new:
[10.6.***.202] [18/Oct/2019:01:05:15 +0000] TCP 200 4333 81 0.002
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #No GH issue so far , if it's required, I will fire one.
Special notes for your reviewer: