-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update documentation for static ip example #4748
Conversation
Welcome @argeas! |
Hi @argeas. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Codecov Report
@@ Coverage Diff @@
## master #4748 +/- ##
==========================================
+ Coverage 58.6% 58.62% +0.01%
==========================================
Files 88 88
Lines 6743 6743
==========================================
+ Hits 3952 3953 +1
+ Misses 2355 2353 -2
- Partials 436 437 +1
Continue to review full report at Codecov.
|
/lgtm |
@argeas thanks! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, argeas The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is just a documentation/example maintenance PR since I was using the examples to setup my Nginx and ran into the issues described in the commit messages.