-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove lua-resty-waf feature #4779
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4779 +/- ##
=========================================
Coverage ? 58.72%
=========================================
Files ? 88
Lines ? 6770
Branches ? 0
=========================================
Hits ? 3976
Misses ? 2363
Partials ? 431
Continue to review full report at Codecov.
|
Out of curiosity, is there a reason why we plan to remove this feature? @aledbf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, cmluciano The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I guess we could easily put this back in through the custom plugin system if we really want this feature. |
@imjching ingress-nginx have custom plugin system ? |
What this PR does / why we need it:
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #Special notes for your reviewer: