Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove lua-resty-waf feature #4779

Merged
merged 1 commit into from
Nov 27, 2019
Merged

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Nov 26, 2019

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 26, 2019
@codecov-io
Copy link

codecov-io commented Nov 26, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@9f72cb3). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4779   +/-   ##
=========================================
  Coverage          ?   58.72%           
=========================================
  Files             ?       88           
  Lines             ?     6770           
  Branches          ?        0           
=========================================
  Hits              ?     3976           
  Misses            ?     2363           
  Partials          ?      431
Impacted Files Coverage Δ
internal/ingress/annotations/annotations.go 80.45% <ø> (ø)
internal/ingress/controller/controller.go 51.56% <ø> (ø)
internal/ingress/types_equals.go 17.49% <ø> (ø)
internal/ingress/types.go 0% <ø> (ø)
internal/ingress/controller/template/template.go 80.24% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f72cb3...61d902d. Read the comment docs.

@imjching
Copy link

Out of curiosity, is there a reason why we plan to remove this feature? @aledbf

Copy link
Contributor

@cmluciano cmluciano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 27, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, cmluciano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit a85d5ed into kubernetes:master Nov 27, 2019
@aledbf aledbf deleted the update-image branch November 29, 2019 18:21
@vietwow
Copy link

vietwow commented Dec 8, 2019

@aledbf the same question as @imjching , could you please to share reason why we remove this feature ? Thanks

@aledbf
Copy link
Member Author

aledbf commented Dec 9, 2019

@vietwow @imjching the main reasons are related to issues building the image, the project not being active, and also it was not possible to use it in ARM.

@imjching
Copy link

imjching commented Dec 9, 2019

I guess we could easily put this back in through the custom plugin system if we really want this feature.

@vietwow
Copy link

vietwow commented Dec 9, 2019

@imjching ingress-nginx have custom plugin system ?

@imjching
Copy link

imjching commented Dec 9, 2019

@vietwow Yes, it was merged in #3807. It seems like it is still an MVP system, but it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants