-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a datasource variable $DS_PROMETHEUS #4797
Conversation
Hi @pauvos. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
@pauvos thanks! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, pauvos The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #4797 +/- ##
==========================================
- Coverage 58.59% 58.57% -0.02%
==========================================
Files 88 88
Lines 6702 6702
==========================================
- Hits 3927 3926 -1
- Misses 2349 2351 +2
+ Partials 426 425 -1
Continue to review full report at Codecov.
|
/retest |
What this PR does / why we need it: Current grafana dashboard does not work with dashboard provisioning (e.g. the default prometheus-operator setup) due to missing
$DS_PROMETHEUS
datasource.Which issue this PR fixes: fixes #4190
Special notes for your reviewer: