Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a datasource variable $DS_PROMETHEUS #4797

Merged
merged 1 commit into from
Dec 2, 2019
Merged

Add a datasource variable $DS_PROMETHEUS #4797

merged 1 commit into from
Dec 2, 2019

Conversation

pauvos
Copy link
Contributor

@pauvos pauvos commented Nov 30, 2019

What this PR does / why we need it: Current grafana dashboard does not work with dashboard provisioning (e.g. the default prometheus-operator setup) due to missing $DS_PROMETHEUS datasource.

Which issue this PR fixes: fixes #4190

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 30, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @pauvos. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 30, 2019
@aledbf
Copy link
Member

aledbf commented Dec 2, 2019

/ok-to-test
/lgtm

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 2, 2019
@aledbf
Copy link
Member

aledbf commented Dec 2, 2019

@pauvos thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, pauvos

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 2, 2019
@codecov-io
Copy link

Codecov Report

Merging #4797 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4797      +/-   ##
==========================================
- Coverage   58.59%   58.57%   -0.02%     
==========================================
  Files          88       88              
  Lines        6702     6702              
==========================================
- Hits         3927     3926       -1     
- Misses       2349     2351       +2     
+ Partials      426      425       -1
Impacted Files Coverage Δ
internal/watch/file_watcher.go 80.76% <0%> (-3.85%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46953cc...f5a02c1. Read the comment docs.

@aledbf
Copy link
Member

aledbf commented Dec 2, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit 6429c01 into kubernetes:master Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Datasource named ${DS_PROMETHEUS} was not found
4 participants