Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update nginx image #4862

Merged
merged 5 commits into from
Jan 4, 2020
Merged

Update nginx image #4862

merged 5 commits into from
Jan 4, 2020

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Dec 26, 2019

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

@aledbf aledbf added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 26, 2019
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Dec 26, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 26, 2019
@codecov-io
Copy link

codecov-io commented Dec 26, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@eb3fd57). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #4862   +/-   ##
========================================
  Coverage          ?   58.6%           
========================================
  Files             ?      88           
  Lines             ?    6719           
  Branches          ?       0           
========================================
  Hits              ?    3938           
  Misses            ?    2353           
  Partials          ?     428
Impacted Files Coverage Δ
internal/ingress/controller/util.go 63.88% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb3fd57...1f2820a. Read the comment docs.

@aledbf aledbf added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 26, 2019
@aledbf aledbf force-pushed the update-nginx-image branch 6 times, most recently from 71fbf30 to ab6faee Compare December 27, 2019 15:56
@aledbf
Copy link
Member Author

aledbf commented Dec 27, 2019

/retest

@aledbf
Copy link
Member Author

aledbf commented Dec 27, 2019

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 27, 2019
@aledbf
Copy link
Member Author

aledbf commented Dec 27, 2019

/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 27, 2019
@aledbf aledbf mentioned this pull request Dec 28, 2019
Closed
@aledbf
Copy link
Member Author

aledbf commented Dec 28, 2019

/retest

1 similar comment
@aledbf
Copy link
Member Author

aledbf commented Dec 28, 2019

/retest

@aledbf aledbf merged commit b30115a into kubernetes:master Jan 4, 2020
@aledbf aledbf deleted the update-nginx-image branch January 4, 2020 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmluciano cmluciano Awaiting requested review from cmluciano

@ElvinEfendi ElvinEfendi Awaiting requested review from ElvinEfendi

Assignees

@ElvinEfendi ElvinEfendi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aledbf @k8s-ci-robot @codecov-io @ndruwizz @ElvinEfendi