Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove todo from lua test #4894

Merged
merged 1 commit into from
Jan 8, 2020
Merged

Remove todo from lua test #4894

merged 1 commit into from
Jan 8, 2020

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Jan 7, 2020

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 7, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 7, 2020
@codecov-io
Copy link

Codecov Report

Merging #4894 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4894      +/-   ##
==========================================
- Coverage    58.5%   58.49%   -0.02%     
==========================================
  Files          88       88              
  Lines        6719     6719              
==========================================
- Hits         3931     3930       -1     
- Misses       2359     2361       +2     
+ Partials      429      428       -1
Impacted Files Coverage Δ
internal/watch/file_watcher.go 80.76% <0%> (-3.85%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e093130...e1a722f. Read the comment docs.

@aledbf
Copy link
Member Author

aledbf commented Jan 7, 2020

/retest

1 similar comment
@aledbf
Copy link
Member Author

aledbf commented Jan 7, 2020

/retest

@aledbf aledbf merged commit a8c2c9c into kubernetes:master Jan 8, 2020
@aledbf aledbf deleted the lua-test branch January 9, 2020 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants