Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dump kind logs after e2e tests #4987

Merged
merged 1 commit into from
Jan 30, 2020
Merged

Dump kind logs after e2e tests #4987

merged 1 commit into from
Jan 30, 2020

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Jan 30, 2020

What this PR does / why we need it:

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Which issue/s this PR fixes

How Has This Been Tested?

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 30, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 30, 2020
@codecov-io
Copy link

codecov-io commented Jan 30, 2020 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@5d05e19). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4987   +/-   ##
=========================================
  Coverage          ?   58.62%           
=========================================
  Files             ?       88           
  Lines             ?     6765           
  Branches          ?        0           
=========================================
  Hits              ?     3966           
  Misses            ?     2367           
  Partials          ?      432

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d05e19...955d98e. Read the comment docs.

@aledbf
Copy link
Member Author

aledbf commented Jan 30, 2020

/test all

13 similar comments
@aledbf
Copy link
Member Author

aledbf commented Jan 30, 2020

/test all

@aledbf
Copy link
Member Author

aledbf commented Jan 30, 2020

/test all

@aledbf
Copy link
Member Author

aledbf commented Jan 30, 2020

/test all

@aledbf
Copy link
Member Author

aledbf commented Jan 30, 2020

/test all

@aledbf
Copy link
Member Author

aledbf commented Jan 30, 2020

/test all

@aledbf
Copy link
Member Author

aledbf commented Jan 30, 2020

/test all

@aledbf
Copy link
Member Author

aledbf commented Jan 30, 2020

/test all

@aledbf
Copy link
Member Author

aledbf commented Jan 30, 2020

/test all

@aledbf
Copy link
Member Author

aledbf commented Jan 30, 2020

/test all

@aledbf
Copy link
Member Author

aledbf commented Jan 30, 2020

/test all

@aledbf
Copy link
Member Author

aledbf commented Jan 30, 2020

/test all

@aledbf
Copy link
Member Author

aledbf commented Jan 30, 2020

/test all

@aledbf
Copy link
Member Author

aledbf commented Jan 30, 2020

/test all

@aledbf
Copy link
Member Author

aledbf commented Jan 30, 2020

/retest

@aledbf aledbf merged commit 1119281 into kubernetes:master Jan 30, 2020
@aledbf aledbf deleted the kind branch January 31, 2020 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmluciano cmluciano Awaiting requested review from cmluciano

@ElvinEfendi ElvinEfendi Awaiting requested review from ElvinEfendi

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aledbf @k8s-ci-robot @codecov-io