docs(deploy): fix helm install command for helm v3

[armujahid]

What this PR does / why we need it:

It's just a doc change in deployment section related to installation via helm.
--name flag has been removed from helm and is now mandatory
helm install [NAME] [CHART] [flags]

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Which issue/s this PR fixes

How Has This Been Tested?

Checklist:

• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I've read the CONTRIBUTION guide
• I have added tests to cover my changes.
• All new and existing tests passed.

[k8s-ci-robot]

Welcome @armujahid!

It looks like this is your first PR to kubernetes/ingress-nginx 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/ingress-nginx has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @armujahid. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[armujahid]

/ok-to-test

[k8s-ci-robot]

@armujahid: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[armujahid]

/assign @ElvinEfendi

[aledbf]

@armujahid please add a different section for helm3 instead of the proposed change. We cannot assume everyone is using the new version.

[armujahid]

@aledbf I have added both helm 3 and 2 related commands in same section (without creating a new section). Default helm site https://helm.sh/ is for stable helm 3 that's why I think we should show helm 3 commands before helm 2. What do you think? I can modify it if required.

[aledbf]

/ok-to-test

[aledbf]

I have added both helm 3 and 2 related commands in same section (without creating a new section).

👍

[aledbf]

/lgtm
/approve

[aledbf]

@armujahid thanks!

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, armujahid

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [aledbf]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[aledbf]

/retest

[aledbf]

/retest

[aledbf]

/retest

[codecov-io]

Codecov Report

Merging #5020 into master will increase coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #5020      +/-   ##
=========================================
+ Coverage   58.55%   58.6%   +0.04%     
=========================================
  Files          88      88              
  Lines        6840    6843       +3     
=========================================
+ Hits         4005    4010       +5     
+ Misses       2398    2397       -1     
+ Partials      437     436       -1

Impacted Files	Coverage Δ
internal/ingress/metric/collectors/socket.go	79.14% <0%> (+0.08%)	⬆️
internal/ingress/metric/collectors/process.go	90.62% <0%> (+2.32%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update beb1b97...d2ea77e. Read the comment docs.

[aledbf]

/retest

[aledbf]

/retest

[aledbf]

/test pull-ingress-nginx-e2e-1-17

[aledbf]

/retest

[aledbf]

/retest

[aledbf]

/retest

[k8s-ci-robot]

@armujahid: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
pull-ingress-nginx-e2e-1-17	d2ea77e	link	/test pull-ingress-nginx-e2e-1-17

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.