-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the handling of ConfigMap creation #5052
Conversation
When a new CM is created Ingress definitions are checked for reference to the new CM an Ingress sync is triggered if such reference is found.
Hi @janosi. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Codecov Report
@@ Coverage Diff @@
## master #5052 +/- ##
=========================================
Coverage ? 58.49%
=========================================
Files ? 88
Lines ? 6865
Branches ? 0
=========================================
Hits ? 4016
Misses ? 2409
Partials ? 440
Continue to review full report at Codecov.
|
/lgtm |
@janosi thanks! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, janosi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Before this PR there was no reference to
@janosi any chance you can add e2e test for this regression? |
@ElvinEfendi Yes, that is my understanding. Let's see if I can work on that e2e. |
What this PR does / why we need it:
Requested in #4969 at #4969 (comment)
When a new CM is created Ingress definitions are checked for reference to the new CM an Ingress sync is triggered if such reference is found.
Types of changes
Which issue/s this PR fixes
How Has This Been Tested?
Checklist: