Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove comment from e2e_test.go #5094

Merged
merged 1 commit into from
Feb 17, 2020
Merged

Remove comment from e2e_test.go #5094

merged 1 commit into from
Feb 17, 2020

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Feb 17, 2020

What this PR does / why we need it:

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Which issue/s this PR fixes

How Has This Been Tested?

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 17, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 17, 2020
@codecov-io
Copy link

Codecov Report

Merging #5094 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5094   +/-   ##
=======================================
  Coverage   58.65%   58.65%           
=======================================
  Files          88       88           
  Lines        6850     6850           
=======================================
  Hits         4018     4018           
  Misses       2391     2391           
  Partials      441      441

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f820618...83b494c. Read the comment docs.

@aledbf
Copy link
Member Author

aledbf commented Feb 17, 2020

/retest

1 similar comment
@aledbf
Copy link
Member Author

aledbf commented Feb 17, 2020

/retest

@aledbf aledbf merged commit ca34f39 into kubernetes:master Feb 17, 2020
@aledbf aledbf deleted the clean branch February 17, 2020 12:16
towolf pushed a commit to towolf/ingress-nginx that referenced this pull request Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants