Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New e2e test: log-format-escape-json and log-format-upstream #5097

Merged
merged 1 commit into from
Feb 17, 2020
Merged

New e2e test: log-format-escape-json and log-format-upstream #5097

merged 1 commit into from
Feb 17, 2020

Conversation

szombi
Copy link
Contributor

@szombi szombi commented Feb 17, 2020

What this PR does / why we need it:

Test log-format-escape-json and log-format-upstream config map values.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Which issue/s this PR fixes

How Has This Been Tested?

make FOCUS="Settings - Log format" kind-e2e-test

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 17, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @szombi. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 17, 2020
@szombi szombi changed the title E2e log format New e2e test: log-format-escape-json and log-format-upstream Feb 17, 2020
@aledbf
Copy link
Member

aledbf commented Feb 17, 2020

@szombi also, please squash the commits

@aledbf
Copy link
Member

aledbf commented Feb 17, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 17, 2020
@codecov-io
Copy link

codecov-io commented Feb 17, 2020 •
edited
Loading

Codecov Report

Merging #5097 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5097   +/-   ##
=======================================
  Coverage   58.65%   58.65%           
=======================================
  Files          88       88           
  Lines        6850     6850           
=======================================
  Hits         4018     4018           
  Misses       2391     2391           
  Partials      441      441

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c4155d...8470a06. Read the comment docs.

@szombi szombi force-pushed the e2e-log-format branch 2 times, most recently from 01b293b to 850d8dd Compare February 17, 2020 12:22
@aledbf
Copy link
Member

aledbf commented Feb 17, 2020

@szombi this LGTM, just remove the commit "Merge remote-tracking branch 'upstream/master'" and we are ok.

@aledbf
Copy link
Member

aledbf commented Feb 17, 2020

/retest

@szombi
Copy link
Contributor Author

szombi commented Feb 17, 2020

done

@aledbf
Copy link
Member

aledbf commented Feb 17, 2020

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 17, 2020
@aledbf
Copy link
Member

aledbf commented Feb 17, 2020

@szombi thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, szombi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 17, 2020
@aledbf
Copy link
Member

aledbf commented Feb 17, 2020

/retest

2 similar comments
@aledbf
Copy link
Member

aledbf commented Feb 17, 2020

/retest

@szombi
Copy link
Contributor Author

szombi commented Feb 17, 2020

/retest

@k8s-ci-robot k8s-ci-robot merged commit 24ce209 into kubernetes:master Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aledbf aledbf aledbf left review comments

@cmluciano cmluciano Awaiting requested review from cmluciano

Assignees

@aledbf aledbf

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@szombi @k8s-ci-robot @aledbf @codecov-io