-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added basic limit-rate configmap test. #5109
Conversation
Hi @SzekeresB. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/lgtm |
Codecov Report
@@ Coverage Diff @@
## master #5109 +/- ##
==========================================
- Coverage 58.68% 58.65% -0.03%
==========================================
Files 88 88
Lines 6850 6850
==========================================
- Hits 4020 4018 -2
- Misses 2390 2391 +1
- Partials 440 441 +1
Continue to review full report at Codecov.
|
/retest |
c53c353
to
c47aa3c
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, SzekeresB The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Adds basic test for limit-rate configmap parameter.
Types of changes
Which issue/s this PR fixes
None
How Has This Been Tested?
$ make FOCUS="Configmap - limit-rate" kind-e2e-test
Checklist: