-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ingress-path-matching: doc typo #5111
Conversation
A small typo in the README describing the path matching.
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @cep21! |
Hi @cep21. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @ElvinEfendi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
This looks good to me and makes sense with the example, I had a hard time trying to test some of these out in an online regex tester
Codecov Report
@@ Coverage Diff @@
## master #5111 +/- ##
==========================================
+ Coverage 58.65% 58.68% +0.02%
==========================================
Files 88 88
Lines 6850 6850
==========================================
+ Hits 4018 4020 +2
+ Misses 2391 2390 -1
+ Partials 441 440 -1
Continue to review full report at Codecov.
|
/lgtm |
@cep21 thanks! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, cep21 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
A small typo in the README describing the path matching.
What this PR does / why we need it:
Small documentation typo
Types of changes
How Has This Been Tested?
Just documentation change.
Checklist: