Update helm templates to match new chart name

[ChiefAlexander]

What this PR does / why we need it:

As we have renamed the helm chart we need to update all of the templates to reflect the new name.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Which issue/s this PR fixes

This PR is based on #5185 which should be merged first. Then I will rebase on it.

How Has This Been Tested?

Checklist:

• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I've read the CONTRIBUTION guide
• I have added tests to cover my changes.
• All new and existing tests passed.

[k8s-ci-robot]

Welcome @ChiefAlexander!

It looks like this is your first PR to kubernetes/ingress-nginx 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/ingress-nginx has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @ChiefAlexander. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[aledbf]

/ok-to-test

[kfox1111]

TL;DR This will actually be problematic for existing users. Please either revert, or enable a value to make this configurable back to the old style

Longer version:
some of us are launching nginx-ingress charts per project. This means we have a lot of them.

We deploy them with service.type=LoadBalancer. This means they get an ip address and/or load balancer dynamically generated with a resulting static ip address. These static ip addresses are then added to DNS.

If we were to upgrade to this chart, the svc name would change, the old svc would get deleted and the ip address would be returned to the pool (perhaps even unexpectedly). We would have to redeploy all of our services and then update dns for every service.

If the service could keep its old name, this whole problem can be avoided as it would simply upgrade around the existing service.

[ChiefAlexander]

The value fullnameOverride allows users to override the generated name and should already provide that functionality.
Testing using stable/nginx-ingress provides a service name of: release-name-nginx-ingress-controller
Testing here using the fullnameOverride with a value set to release-name-nginx-ingress provides a service name of: release-name-nginx-ingress-controller

helm template -x templates/controller-service.yaml --set fullnameOverride=release-name-nginx-ingress ./ingress-nginx

I am not crazy about putting into the chart different generators for backwards compatibility, but it is worth more discussion as there will be other breaking changes that might put off users from switching to this version. EG the selectors changing on the deployment.

[aledbf]

@ChiefAlexander please squash the commits

[aledbf]

/approve

[aledbf]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, ChiefAlexander

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [aledbf]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment