Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add e2e test for OCSP and new configmap setting #5387

Merged
merged 1 commit into from
Apr 17, 2020

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Apr 17, 2020

What this PR does / why we need it:

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Which issue/s this PR fixes

How Has This Been Tested?

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 17, 2020
@aledbf
Copy link
Member Author

aledbf commented Apr 17, 2020

/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 17, 2020
@aledbf
Copy link
Member Author

aledbf commented Apr 17, 2020

/assign @ElvinEfendi

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 17, 2020
@codecov-io
Copy link

codecov-io commented Apr 17, 2020

Codecov Report

Merging #5387 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5387   +/-   ##
=======================================
  Coverage   58.64%   58.64%           
=======================================
  Files          88       88           
  Lines        6913     6913           
=======================================
  Hits         4054     4054           
  Misses       2414     2414           
  Partials      445      445           
Impacted Files Coverage Δ
internal/ingress/controller/template/configmap.go 76.41% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e8c68d...57c7ea7. Read the comment docs.

@aledbf
Copy link
Member Author

aledbf commented Apr 17, 2020

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 17, 2020
@aledbf
Copy link
Member Author

aledbf commented Apr 17, 2020

/retest

@aledbf
Copy link
Member Author

aledbf commented Apr 17, 2020

/test all

@aledbf
Copy link
Member Author

aledbf commented Apr 17, 2020

/retest

4 similar comments
@aledbf
Copy link
Member Author

aledbf commented Apr 17, 2020

/retest

@aledbf
Copy link
Member Author

aledbf commented Apr 17, 2020

/retest

@aledbf
Copy link
Member Author

aledbf commented Apr 17, 2020

/retest

@aledbf
Copy link
Member Author

aledbf commented Apr 17, 2020

/retest

@aledbf
Copy link
Member Author

aledbf commented Apr 17, 2020

/test pull-ingress-nginx-e2e-1-16

@k8s-ci-robot
Copy link
Contributor

@aledbf: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-ingress-nginx-e2e-1-16 57c7ea7 link /test pull-ingress-nginx-e2e-1-16

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@aledbf
Copy link
Member Author

aledbf commented Apr 17, 2020

Merging. In a new PR the e2e image will be updated with cfssl binaries and new cfssl docker image

@aledbf aledbf merged commit d18fa90 into kubernetes:master Apr 17, 2020
@aledbf aledbf deleted the ocsp branch April 17, 2020 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants