Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve build time of httpbin e2e test image #5419

Merged
merged 1 commit into from
Apr 22, 2020
Merged

Improve build time of httpbin e2e test image #5419

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions images/httpbin/rootfs/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,14 @@ FROM alpine:3.11
ENV LC_ALL=C.UTF-8
ENV LANG=C.UTF-8

RUN apk add --no-cache \
python3 python3-dev musl-dev gcc g++ make libffi libffi-dev libstdc++ \
&& pip3 install gunicorn httpbin gevent \
RUN echo "@edge http://nl.alpinelinux.org/alpine/edge/main" >> /etc/apk/repositories \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how's this improving the build time?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By half, installing alpine packages instead of using pip
Times:

&& apk update \
&& apk add --no-cache \
python3 python3-dev \
musl-dev gcc g++ make \
libffi libffi-dev libstdc++ \
py3-gevent py3-gunicorn py3-wheel@edge \
&& pip3 install httpbin \
&& apk del python3-dev musl-dev gcc g++ make libffi-dev

EXPOSE 80
Expand Down