Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ingress validation in webhook #5459

Merged
merged 1 commit into from
Apr 28, 2020
Merged

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Apr 28, 2020

What this PR does / why we need it:

This fixes an issue with Kubernetes v1.18 where a default PathType is configured by default.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Which issue/s this PR fixes

fixes #5457

How Has This Been Tested?

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 28, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 28, 2020
@aledbf aledbf force-pushed the webhook branch 2 times, most recently from 8a46610 to e9e99e1 Compare April 28, 2020 16:12
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 28, 2020
@codecov-io
Copy link

Codecov Report

Merging #5459 into master will decrease coverage by 0.26%.
The diff coverage is 55.91%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5459      +/-   ##
==========================================
- Coverage   58.64%   58.37%   -0.27%     
==========================================
  Files          88       88              
  Lines        6913     6946      +33     
==========================================
+ Hits         4054     4055       +1     
- Misses       2414     2445      +31     
- Partials      445      446       +1     
Impacted Files Coverage Δ
cmd/nginx/main.go 5.98% <0.00%> (-0.43%) ⬇️
internal/ingress/controller/template/template.go 79.89% <0.00%> (-0.22%) ⬇️
internal/ingress/types.go 0.00% <ø> (ø)
internal/k8s/main.go 52.17% <0.00%> (-17.06%) ⬇️
internal/ingress/annotations/class/main.go 54.54% <50.00%> (-34.35%) ⬇️
internal/ingress/controller/controller.go 49.58% <83.33%> (+0.18%) ⬆️
internal/ingress/controller/store/store.go 59.78% <83.33%> (-0.30%) ⬇️
internal/admission/controller/main.go 90.47% <96.77%> (+4.36%) ⬆️
internal/admission/controller/server.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d2c6db...810de33. Read the comment docs.

@aledbf
Copy link
Member Author

aledbf commented Apr 28, 2020

/retest

@aledbf aledbf merged commit af910a1 into kubernetes:master Apr 28, 2020
@aledbf aledbf deleted the webhook branch April 28, 2020 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ingress 0.31.0 and 0.31.1 fails with duplicate location /
3 participants