-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix error setting $service_name NGINX variable #5536
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #5536 +/- ##
==========================================
- Coverage 58.56% 58.54% -0.02%
==========================================
Files 88 88
Lines 6948 6950 +2
==========================================
Hits 4069 4069
- Misses 2431 2432 +1
- Partials 448 449 +1
Continue to review full report at Codecov.
|
Where did the regression got introduced? |
Check the issue #5515 |
@ElvinEfendi just in case this issue only happens when the $service_name variable is used to route traffic, like using linkerd. |
/retest |
1 similar comment
/retest |
/assign @ElvinEfendi |
/retest |
What this PR does / why we need it:
Types of changes
Which issue/s this PR fixes
fixes #5515
How Has This Been Tested?
Checklist: