Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validation support for networking.k8s.io/v1 #6187

Merged
merged 1 commit into from
Sep 17, 2020

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Sep 17, 2020

What this PR does / why we need it:

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Which issue/s this PR fixes

How Has This Been Tested?

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 17, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 17, 2020
@aledbf
Copy link
Member Author

aledbf commented Sep 17, 2020

/retest

@aledbf aledbf merged commit 38fc35f into kubernetes:master Sep 17, 2020
@aledbf aledbf deleted the webhook branch September 17, 2020 12:05
@haslersn
Copy link
Contributor

Is this contained in release 3.3.0? With this deployed I still get

Error presenting challenge: admission webhook "validate.nginx.ingress.kubernetes.io" denied the request: rejecting admission review because the request does not contains an Ingress resource but networking.k8s.io/v1, Resource=ingresses with name cm-acme-http-solver-kxggk in namespace testnamespace

on kubectl describe challenge -A (using cert-manager).

@aledbf
Copy link
Member Author

aledbf commented Sep 29, 2020

@haslersn no, this change is not released yet. This requires a release of the ingress controller and then a helm chart update

@haslersn
Copy link
Contributor

For the naive me it looks like this is released because it's in the branch ingress-nginx-3.3.0. Is there a workaround in order to already get this change?

@aledbf
Copy link
Member Author

aledbf commented Sep 29, 2020

Is there a workaround in order to already get this change?

You can use the current staging ingress-nginx image gcr.io/k8s-staging-ingress-nginx/controller:v0.35.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants