Delete OCSP Response cache when certificate renewed

[wenzong]

Delete OCSP Response cache when certificate renewed

What this PR does / why we need it:

Use OCSP Stapling along with cert-manager auto-renew certificate will cause mismatch between OCSP Response and the certificate.

Types of changes

• Bug fix (non-breaking change which fixes an issue)

Which issue/s this PR fixes

How Has This Been Tested?

$ make lua-test
147 successes / 0 failures / 0 errors / 0 pending : 1.62225 seconds

Checklist:

• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I've read the CONTRIBUTION guide
• I have added tests to cover my changes.
• All new and existing tests passed.

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
• Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: login-issues@jira.linuxfoundation.org

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[k8s-ci-robot]

Welcome @wenzong!

It looks like this is your first PR to kubernetes/ingress-nginx 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/ingress-nginx has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @wenzong. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[wenzong]

@k8s-ci-robot I signed it!

[wenzong]

/assign @aledbf

[wenzong]

More information describe in this issue #5397 (comment)

The fix is discussed with @ElvinEfendi #5397 (comment)

[aledbf]

/assign @ElvinEfendi

[aledbf]

/ok-to-test

[ElvinEfendi]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ElvinEfendi, wenzong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ElvinEfendi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[wi1dcard]

A small out-of-topic question: is there any schedule of releasing 0.36.0? Or is there any chance that we can release another patch version soon? This is a little bit annoying after any individual TLS certificate gets renewed as we're using cert-manager and ingress-nginx.

[wi1dcard]

Just give people an idea who might have the similar issue:

This PR might be able to resolve the OCSP stapling issue after a cert renewal. We received a report from one of our users who uses Firefox always getting MOZILLA_PKIX_ERROR_OCSP_RESPONSE_FOR_CERT_MISSING error in recent days. The ssllabs test showed that OCSP stapling -> Invalid   No response provided.

A workaround before a new version released - delete (and recreate) all pods of ingress-nginx and the cache should be reconstructed:

kubectl rollout restart deployment nginx-ingress-controller

Get all certificates and their expected renewal dates:

kubectl get cert --all-namespaces -o json | jq -r '.items[] | [.status.renewalTime,.metadata.name,.metadata.namespace] | @tsv' | sort | sed -e '1i\RENEWAL-DATE\tCERT\tNAMESPACE' | column -t

RENEWAL-DATE          CERT                                     NAMESPACE
2020-11-12T03:38:46Z  grafana                                  prometheus
2020-11-18T00:47:00Z  alertmanager                             prometheus
2020-11-18T00:47:00Z  prometheus                               prometheus

Manually trigger renewal using the cert-manager kubectl plugin:

kubectl cert-manager renew alertmanager