-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update annotations.md - improvements to the documentation of Client Certificate Authentication #6214
Conversation
Improvements to the documentation of Client Certificate Authentication. (auth-tls-* annotations). - Mention that these rules are applied per host and not per Ingress/path - Include more possible and default values - Describe the headers that are sent to the upstream services
Welcome @daniel-kun! |
Hi @daniel-kun. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/lgtm |
@daniel-kun thanks! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aledbf, daniel-kun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Improvements to the documentation of Client Certificate Authentication. (auth-tls-* annotations).
What this PR does / why we need it:
The docs on the aut-tls-* annotations was missing a few important details, which I added.
Types of changes
(Only documentation)
How Has This Been Tested?
I proof-read the changes and did a few local experiments with the annotations to verify the described behaviour.
Checklist: