Use net.Listen func to ensure the port is free #6990

boxjan · 2021-03-25T13:53:56Z

What this PR does / why we need it:

Fro the issue, I meet the problem here #6988 ; and I fixed it after I change the judgment method.

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Which issue/s this PR fixes

How Has This Been Tested?

I make a image and deploy it in my cluster which I meet the problem in the issue, then the problem disappeared. I reboot some node, and the problem no happen again.
My image link (docker hub)

Checklist:

My change requires a change to the documentation.
I have updated the documentation accordingly.
I've read the CONTRIBUTION guide
I have added tests to cover my changes.
All new and existing tests passed.

k8s-ci-robot · 2021-03-25T13:53:59Z

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: login-issues@jira.linuxfoundation.org

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-ci-robot · 2021-03-25T13:54:04Z

Welcome @boxjan!

It looks like this is your first PR to kubernetes/ingress-nginx 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/ingress-nginx has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2021-03-25T13:54:04Z

Hi @boxjan. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

boxjan · 2021-04-07T16:32:30Z

/assign @ElvinEfendi

boxjan · 2021-04-09T18:15:39Z

/assign @cmluciano

rikatz · 2021-06-27T22:20:18Z

/ok-to-test

rikatz · 2021-06-27T22:23:10Z

internal/net/net.go

@@ -29,12 +29,12 @@ func IsIPV6(ip _net.IP) bool {

 // IsPortAvailable checks if a TCP port is available or not
 func IsPortAvailable(p int) bool {
-	conn, err := _net.Dial("tcp", fmt.Sprintf(":%v", p))
+	ln, err := _net.Listen("tcp", fmt.Sprintf(":%v", p))


Cant it be a problem if we try to bind nginx to a specific IP, but here you check all the interfaces?

https://kubernetes.github.io/ingress-nginx/user-guide/nginx-configuration/configmap/#bind-address <- we should probably check against this address specifically:

If it does not exists, we may try binding to every address

If this exists, then we should try to bind specifically to this address

Yes, you are right, I just did a workaround let it can run in my cluster. I will try to change it under your suggested.

@rikatz but the function was use in init check, so it will change so many things.

hum indeed, this value is in ConfigMap and it's not a flag...

OK, so overall this problem would still happen if we have something listening in the port, I think we can go forward with this one.

rikatz · 2021-07-04T22:19:33Z

/lgtm
/approve
Let's keep an eye in the future if this change brings other problems as I described in the PR review. While that, thanks for the contribution :)

k8s-ci-robot · 2021-07-04T22:19:41Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: boxjan, rikatz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [rikatz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

chessman · 2021-08-03T07:20:12Z

Is it possible to backport this PR to 0.48.x?

Co-authored-by: boxjan <i@boxjan.li>

) Co-authored-by: boxjan <i@boxjan.li>

k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Mar 25, 2021

k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 25, 2021

k8s-ci-robot requested review from cmluciano and ElvinEfendi March 25, 2021 13:54

use listen to ensure the port is free

bdaf3e5

boxjan force-pushed the master branch from 0c6e69c to bdaf3e5 Compare March 25, 2021 14:08

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 25, 2021

boxjan changed the title ~~Use listen to ensure the port is free~~ Use net.Listen func to ensure the port is free Mar 28, 2021

k8s-ci-robot assigned ElvinEfendi Apr 7, 2021

k8s-ci-robot assigned cmluciano Apr 9, 2021

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 27, 2021

rikatz reviewed Jun 27, 2021

View reviewed changes

k8s-ci-robot assigned rikatz Jul 4, 2021

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 4, 2021

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 4, 2021

k8s-ci-robot merged commit 0c685c1 into kubernetes:master Jul 4, 2021

tao12345666333 mentioned this pull request Jul 27, 2021

port 80 is free, but nginx-ingress-controller say already in use #6988

Closed

chessman pushed a commit to chessman/ingress-nginx that referenced this pull request Aug 9, 2021

use listen to ensure the port is free (kubernetes#6990)

9ae0b97

chessman mentioned this pull request Aug 9, 2021

use listen to ensure the port is free (#6990) #7467

Merged

8 tasks

k8s-ci-robot pushed a commit that referenced this pull request Aug 9, 2021

use listen to ensure the port is free (#6990) (#7467)

af745bd

Co-authored-by: boxjan <i@boxjan.li>

aureq mentioned this pull request Oct 30, 2021

Chart Option bind-address is not honored at startup and causes nginx to fail #7859

Closed

rchshld pushed a commit to joomcode/ingress-nginx that referenced this pull request May 19, 2023

use listen to ensure the port is free (kubernetes#6990) (kubernetes#7467

240c185

) Co-authored-by: boxjan <i@boxjan.li>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use net.Listen func to ensure the port is free #6990

Use net.Listen func to ensure the port is free #6990

boxjan commented Mar 25, 2021

k8s-ci-robot commented Mar 25, 2021

k8s-ci-robot commented Mar 25, 2021

k8s-ci-robot commented Mar 25, 2021

boxjan commented Apr 7, 2021

boxjan commented Apr 9, 2021

rikatz commented Jun 27, 2021

rikatz Jun 27, 2021

rikatz Jun 27, 2021

boxjan Jun 28, 2021

boxjan Jun 28, 2021

rikatz Jul 4, 2021

rikatz commented Jul 4, 2021

k8s-ci-robot commented Jul 4, 2021

chessman commented Aug 3, 2021

Use net.Listen func to ensure the port is free #6990

Use net.Listen func to ensure the port is free #6990

Conversation

boxjan commented Mar 25, 2021

What this PR does / why we need it:

Types of changes

Which issue/s this PR fixes

How Has This Been Tested?

Checklist:

k8s-ci-robot commented Mar 25, 2021

k8s-ci-robot commented Mar 25, 2021

k8s-ci-robot commented Mar 25, 2021

boxjan commented Apr 7, 2021

boxjan commented Apr 9, 2021

rikatz commented Jun 27, 2021

rikatz Jun 27, 2021

Choose a reason for hiding this comment

rikatz Jun 27, 2021

Choose a reason for hiding this comment

boxjan Jun 28, 2021

Choose a reason for hiding this comment

boxjan Jun 28, 2021

Choose a reason for hiding this comment

rikatz Jul 4, 2021

Choose a reason for hiding this comment

rikatz commented Jul 4, 2021

k8s-ci-robot commented Jul 4, 2021

chessman commented Aug 3, 2021