Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare for v0.45.0 release #7026

Merged
merged 3 commits into from
Apr 6, 2021
Merged

Prepare for v0.45.0 release #7026

merged 3 commits into from
Apr 6, 2021

Conversation

rikatz
Copy link
Contributor

@rikatz rikatz commented Apr 6, 2021

Fixes: #6935

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 6, 2021
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Apr 6, 2021
ElvinEfendi
ElvinEfendi reviewed Apr 6, 2021
View reviewed changes
Changelog.md Outdated Show resolved Hide resolved
@rikatz @ElvinEfendi
Apply suggestions from code review
1b94975 
Co-authored-by: Elvin Efendi <elvin.efendiyev@gmail.com>
@rikatz
Copy link
Contributor Author

rikatz commented Apr 6, 2021

/label tide/merge-method-squach

@k8s-ci-robot
Copy link
Contributor

@rikatz: The label(s) /label tide/merge-method-squach cannot be applied. These labels are supported: api-review, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash

In response to this:

/label tide/merge-method-squach

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rikatz
Copy link
Contributor Author

rikatz commented Apr 6, 2021

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Apr 6, 2021
@ElvinEfendi
Copy link
Member

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ElvinEfendi, rikatz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 6, 2021
@k8s-ci-robot k8s-ci-robot merged commit ed5aee7 into kubernetes:master Apr 6, 2021
qiqizjl pushed a commit to qiqizjl/ingress-nginx that referenced this pull request Jul 7, 2021
@rikatz @ElvinEfendi @qiqizjl
Prepare for v0.45.0 release (kubernetes#7026)
6c8bb74 
* Prepare for v0.45.0 release

* Apply suggestions from code review

Co-authored-by: Elvin Efendi <elvin.efendiyev@gmail.com>

* Prepare for v0.45.0 release

Co-authored-by: Elvin Efendi <elvin.efendiyev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ElvinEfendi ElvinEfendi ElvinEfendi left review comments

@cmluciano cmluciano Awaiting requested review from cmluciano

Assignees

@ElvinEfendi ElvinEfendi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
3 participants
@rikatz @k8s-ci-robot @ElvinEfendi