fix ingress-nginx panic when the certificate format is wrong.

[wenhuwang]

Signed-off-by: wang_wenhu 976400757@qq.com

Fix ingress-nginx controller panic when the certificate and rules are misconfigured.

What this PR does / why we need it:

If inpropriate host rule and invalid certificate file are specified, an error will be thrown, and should limited only to current domain, other than bringing down the whole ingress controller.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Which issue/s this PR fixes

fixes #6482

How Has This Been Tested?

How to reproduce it:

In ingress configuration, specify an invalid https certificate file (ill formatted), and the 'host' doesn't exist in 'ingress.spec.rule' section.
Add an ingress yaml:

# cat ingress-test.yaml
apiVersion: networking.k8s.io/v1beta1
kind: Ingress
metadata:
  namespace: demo
  labels:
    app: demo01
  annotations:
    kubesphere.io/creator: wangwenhu007
  name: demo01
spec:
  tls:
    - hosts:
        - aaa.com
      secretName: default-token-dn6xb
  rules:
    - host: aaa.com
      http:
        paths:
          - path: /
            backend:
              serviceName: nginx-e1
              servicePort: 80
    - host: bbb.com
      http:
        paths:
          - path: /
            backend:
              serviceName: nginx-e1
              servicePort: 80

Checklist:

• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I've read the CONTRIBUTION guide
• I have added tests to cover my changes.
• All new and existing tests passed.

[k8s-ci-robot]

@wenhuwang: This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

Welcome @wenhuwang!

It looks like this is your first PR to kubernetes/ingress-nginx 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/ingress-nginx has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @wenhuwang. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[rikatz]

/ok-to-test

[rikatz]

@wenhuwang can you please add some unit test here so we can find regressions?

Suggestion for a test is:

• Add some "secret" with the same format of a service account token (kubectl get secret default-token-9gp9f -o yaml) for example
• Try to add this secret into some ingress, no panic should occur.

Thanks

[wenhuwang]

@wenhuwang can you please add some unit test here so we can find regressions?

Suggestion for a test is:

• Add some "secret" with the same format of a service account token (kubectl get secret default-token-9gp9f -o yaml) for example
• Try to add this secret into some ingress, no panic should occur.

Thanks

hello, please help me review.@rikatz
thank you.

[tao12345666333]

nit: in fact, the content here should be ZGVtbw==
but you did not use it in the following content

[wenhuwang]

nit: in fact, the content here should be ZGVtbw==
but you did not use it in the following content

Yes, it should be ZGVtbw==. I will fix it later.

[wenhuwang]

@tao12345666333 PTAL thanks.

[rikatz]

/kind bug
/priority critical-urgent

[rikatz]

/approve

@tao12345666333 for your verification, as soon as you issue lgtm this gets merged.

Thanks!

[tao12345666333]

/lgtm
/lable tide/mege-methd-squash

[tao12345666333]

/lable tide/mege-method-squash

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rikatz, tao12345666333, wenhuwang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rikatz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[tao12345666333]

/hold

[tao12345666333]

/label tide/merge-method-squash

[tao12345666333]

/hold cancel

[tao12345666333]

/hold cancel