Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for IPV6 in dns resolvers #77

Merged
merged 2 commits into from
Jan 2, 2017

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Dec 22, 2016

@aledbf aledbf self-assigned this Dec 22, 2016
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 22, 2016
@k8s-reviewable
Copy link

This change is Reviewable

@gurvindersingh
Copy link

I am hitting the issue in my current setup, wondering if there will be a release once this patch is merged or should I for now remove ipv6 from resolv.conf ?

@aledbf
Copy link
Member Author

aledbf commented Dec 22, 2016

@gurvindersingh for now remove ipv6 from resolv.conf

@gurvindersingh
Copy link

yeah that's what I did to have a workaround, but wondering about possible 0.8.4 or 0.9.0 with the fix.

@aledbf
Copy link
Member Author

aledbf commented Dec 22, 2016

@gurvindersingh we are still migrating and changing the code. I thin we need a couple of weeks before a release. Apologies for the delay

@gurvindersingh
Copy link

@aledbf thanks the update. Will look forward to the next release.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 39.847% when pulling 77608bf on aledbf:dns-resolver into 8e90fc0 on kubernetes:master.

@aledbf
Copy link
Member Author

aledbf commented Dec 28, 2016

Using

core@localhost ~ $ cat /etc/resolv.conf
nameserver 8.8.8.8
nameserver 2001:4860:4860::8888

and setting dnsPolicy: Default the generated nginx.conf is:

+    access_log /var/log/nginx/access.log upstreaminfo if=$loggable;
+    error_log  /var/log/nginx/error.log notice;
+
+    resolver 8.8.8.8 [2001:4860:4860::8888] valid=30s;
+
+    # Retain the default nginx handling of requests without a "Connection" header
+    map $http_upgrade $connection_upgrade {
+        default          upgrade;
+        ''               close;
+    }

@aledbf aledbf changed the title WIP: Add support for IPV6 in dns resolvers Add support for IPV6 in dns resolvers Dec 28, 2016
@coveralls
Copy link

Coverage Status

Coverage increased (+0.08%) to 39.847% when pulling 61dad19 on aledbf:dns-resolver into 8e90fc0 on kubernetes:master.

@aledbf aledbf mentioned this pull request Dec 29, 2016
@bprashanth
Copy link
Contributor

Thanks, LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. nginx
Projects
None yet
6 participants