-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update anchor links of Nodeport from #nodeport to #type-nodeport #7899
Update anchor links of Nodeport from #nodeport to #type-nodeport #7899
Conversation
@sandipanpanda: This issue is currently awaiting triage. If Ingress contributors determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Welcome @sandipanpanda! |
Hi @sandipanpanda. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rikatz, sandipanpanda The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…bernetes#7899) * Update anchor link from #nodeport to #type-nodeport in baremetal.md * Update anchor link from #nodeport to #type-nodeport in baremetal.md
What this PR does / why we need it:
This PR updates the anchor links of
Nodeport
from https://kubernetes.io/docs/concepts/services-networking/service/#nodeport to https://kubernetes.io/docs/concepts/services-networking/service/#type-nodeport.In kubernetes/website#30388 (comment), we can see that no. of files redirecting to #type-nodeport is 230, whereas for #nodeport it is only 31. Making changes to 230 files is though possible, but would take much toil. Hence, I found updating the latter to be an easy fix and practically feasible.
Types of changes
Which issue/s this PR fixes
How Has This Been Tested?
Checklist: