Add docs and second test into sanitization #7921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rikatz: This issue is currently awaiting triage. If Ingress contributors determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
needs-triage
k8s-ci-robot
added
the
approved
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
rikatz
changed the title
rikatz
force-pushed
the
sanitization-fix-2
branch
from
3348294
to
f84a830
Compare
k8s-ci-robot
added
size/S
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
rikatz
force-pushed
the
sanitization-fix-2
branch
from
f84a830
to
fb34bc4
Compare
theunrealgeek
approved these changes
Nov 15, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rikatz, theunrealgeek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
rikatz
force-pushed
the
sanitization-fix-2
branch
from
fb34bc4
to
e5b9415
Compare
rikatz
added
the
lgtm
rikatz
added a commit
to rikatz/ingress-nginx
that referenced
this pull request
Nov 16, 2021
k8s-ci-robot
pushed a commit
that referenced
this pull request
Nov 16, 2021
* fix: fix thread synchronization issue #6245 (#7800) * Add option to sanitize annotation inputs (#7874) * Add option to sanitize annotation inputs * Fix e2e tests after string sanitization * Add proxy_pass and serviceaccount as denied values * Trim spaces from badword items (#7921) * Fix tests from cherrypick Co-authored-by: Jens Reimann <ctron@dentrassi.de>
rchshld
pushed a commit
to joomcode/ingress-nginx
that referenced
this pull request
May 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add one more unit test just to avoid regressions on the sanitization configmap