Revise main documentation page #8019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
/kind documentation |
k8s-ci-robot
added
kind/documentation
|
/ok-to-test |
|
need to squash commits using bot before approve |
k8s-ci-robot
added
the
ok-to-test
k8s-ci-robot
added
the
lgtm
sftim
force-pushed
the
20211207_fix_class_doc
branch
from
4f89ea1
to
483a122
Compare
k8s-ci-robot
removed
the
lgtm
|
BTW, Prow can preserve LGTM through squashes - see kubernetes/kubernetes#103096 for hints. |
|
/lgtm
Thanks,
; Long
…On Wed, 8 Dec, 2021, 7:38 AM Tim Bannister, ***@***.***> wrote:
BTW, Prow can preserve LGTM through squashes - see
kubernetes/kubernetes#103096
<kubernetes/kubernetes#103096> for hints.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#8019 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABGZVWXERZWB2SNTBZ3IYODUP24Z3ANCNFSM5JR7N6VA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
k8s-ci-robot
added
the
lgtm
k8s-ci-robot
removed
the
lgtm
sftim
force-pushed
the
20211207_fix_class_doc
branch
from
24f497b
to
427bfa7
Compare
|
Thanks for the extra suggestions @tao12345666333 |
sftim
commented
Dec 8, 2021
docs/index.md
Outdated
| @@ -1,31 +1,35 @@ | |||
| # Welcome | |||
| # NGINX Ingress Controller | |||
There was a problem hiding this comment.
Alternatives:
- Leave
# Welcome - Switch to
# Overview
There was a problem hiding this comment.
This will revise the heading on https://kubernetes.github.io/ingress-nginx/
strongjz
reviewed
Dec 8, 2021
strongjz
reviewed
Dec 8, 2021
- Revise to be more in line with the style guide for Kubernetes official docs - Avoid recommending that readers use `k8s.io` namespaced controller names for their own custom controller configuration. Co-authored-by: James Strong <strong.james.e@gmail.com>
sftim
force-pushed
the
20211207_fix_class_doc
branch
from
100379c
to
f3476a9
Compare
k8s-ci-robot
added
the
lgtm
|
/triage accepted |
k8s-ci-robot
added
triage/accepted
|
/approve Thanks :) |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: longwuyuan, rikatz, sftim, tao12345666333 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
rchshld
pushed a commit
to joomcode/ingress-nginx
that referenced
this pull request
May 19, 2023
- Revise to be more in line with the style guide for Kubernetes official docs - Avoid recommending that readers use `k8s.io` namespaced controller names for their own custom controller configuration. Co-authored-by: James Strong <strong.james.e@gmail.com> Co-authored-by: James Strong <strong.james.e@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
k8s.ionamespaced controller names for their own custom controller configuration.(Rather than a name like
k8s.io/ingress-nginx1, readers should either use a private name:ingress-nginx1, or use their own domain as a prefix).Rendered