Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comment busy owners #8035

Merged
merged 2 commits into from
Dec 15, 2021
Merged

Comment busy owners #8035

merged 2 commits into from
Dec 15, 2021

Conversation

rikatz
Copy link
Contributor

@rikatz rikatz commented Dec 12, 2021

As a user, it's frustrating when you add a PR, then wait for someone to review and the bot assign two persons not able to do so :)

We are thankful for all the past reviewers and approvers here and welcome they all to contribute as soon as they are able!

While that, we need to make the bot stop assigning them reviews or approvals and leave users waiting.

And we welcome all the new reviewers and approvers :)

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority labels Dec 12, 2021
@rikatz
Copy link
Contributor Author

rikatz commented Dec 12, 2021

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 12, 2021
@k8s-ci-robot k8s-ci-robot added area/docs approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 12, 2021
tao12345666333
tao12345666333 approved these changes Dec 12, 2021
View reviewed changes
Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 12, 2021
@rikatz
Copy link
Contributor Author

rikatz commented Dec 12, 2021

/hold

Until James agreement as well :)

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 12, 2021
@strongjz
Copy link
Member

/lgtm

@strongjz
Copy link
Member

/triage accepted
/kind support
/priority longterm-important
/hold cancel
/lgtm

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Dec 14, 2021
@k8s-ci-robot
Copy link
Contributor

@strongjz: The label(s) priority/longterm-important cannot be applied, because the repository doesn't have them.

In response to this:

/triage accepted
/kind support
/priority longterm-important
/hold cancel
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added kind/support Categorizes issue or PR as a support question. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Dec 14, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rikatz, strongjz, tao12345666333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rikatz rikatz merged commit 7bae2e7 into kubernetes:main Dec 15, 2021
rchshld pushed a commit to joomcode/ingress-nginx that referenced this pull request May 19, 2023
@rikatz @rchshld
Comment busy owners (kubernetes#8035)
dd65e4a 
* Cleanup owners files

* Cleanup owners files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tao12345666333 tao12345666333 tao12345666333 approved these changes

@ElvinEfendi ElvinEfendi Awaiting requested review from ElvinEfendi

@strongjz strongjz Awaiting requested review from strongjz

Assignees

@strongjz strongjz

@tao12345666333 tao12345666333

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/docs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/support Categorizes issue or PR as a support question. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rikatz @strongjz @k8s-ci-robot @tao12345666333