Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix no endpoints issue when named ports are used #845

Closed
wants to merge 1 commit into from

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Jun 13, 2017

fixes #839

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 13, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@aledbf aledbf requested a review from justinsb June 13, 2017 00:29
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.05%) to 46.508% when pulling a970ef8 on aledbf:fix-named-ports into cdbf2aa on kubernetes:master.

@aledbf aledbf closed this Jun 13, 2017
@justinsb
Copy link
Member

justinsb commented Jun 13, 2017

So I think the matching should be stricter - I put up #846 as my experimentation. Once we find the ServicePort on the Service object, the only way to match that to an EndpointPort is by Name. The only exception is that the ServicePort Name is optional if there is only one port, so in that case we match always.

At least I think so :-)

@aledbf aledbf deleted the fix-named-ports branch June 13, 2017 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"No endpoints" issue
5 participants