Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust the import package order and use http library variables #9587

Merged
merged 1 commit into from
Feb 16, 2023

Conversation

Fish-pro
Copy link
Member

@Fish-pro Fish-pro commented Feb 7, 2023

Signed-off-by: Fish-pro zechun.chen@daocloud.io

What this PR does / why we need it:

Adjust the import package order and use http library variables

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • CVE Report (Scanner found CVE and adding report)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation only

Which issue/s this PR fixes

fixes #9592

How Has This Been Tested?

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have added unit and/or e2e tests to cover my changes.
  • All new and existing tests passed.
  • Added Release Notes.

Signed-off-by: Fish-pro <zechun.chen@daocloud.io>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Feb 7, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 7, 2023
@longwuyuan
Copy link
Contributor

@Fish-pro thanks for your PR.

There is absolutely no details or explaining done in the description section of the PR. I think this looks like some very important improvement. But on the very basics of OSS projects, people who visit this PR or search in future deserve to know details and precise stories with examples and tests. It helps reduce the time a developer needs to get on the same page as you and it also helps improve & document the changes for the users who will use the code.

@Fish-pro
Copy link
Member Author

Fish-pro commented Feb 7, 2023

@Fish-pro thanks for your PR.

There is absolutely no details or explaining done in the description section of the PR. I think this looks like some very important improvement. But on the very basics of OSS projects, people who visit this PR or search in future deserve to know details and precise stories with examples and tests. It helps reduce the time a developer needs to get on the same page as you and it also helps improve & document the changes for the users who will use the code.

@longwuyuan
Thank you for your guidance, I got it

@Fish-pro
Copy link
Member Author

Fish-pro commented Feb 8, 2023

@longwuyuan
I have created the corresponding issue #9592

@rikatz
Copy link
Contributor

rikatz commented Feb 16, 2023

/lgtm
/approve
Thanks

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 16, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Fish-pro, rikatz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 16, 2023
@k8s-ci-robot k8s-ci-robot merged commit 1cdd61f into kubernetes:main Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adjust the import package order and replace http library constants with string
4 participants