Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sort-backends command line option #961

Closed
wants to merge 1 commit into from

Conversation

jcmoraisjr
Copy link
Contributor

This option allows to create a predictable config file in order to compare before/after when developing and debugging. If not specified will use the current approach.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 13, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@aledbf aledbf self-assigned this Jul 13, 2017
@aledbf
Copy link
Member

aledbf commented Jul 13, 2017

@jcmoraisjr out of curiosity, why are you adding this flag?

@aledbf
Copy link
Member

aledbf commented Jul 13, 2017

@jcmoraisjr waiting ci ok to review and merge

@jcmoraisjr
Copy link
Contributor Author

out of curiosity, why are you adding this flag?

Mainly for manual tests and debugging. I generate a cfg file before and after changing something against namespaces with all features HAProxy Ingress supports and check if the changes are expected.

@aledbf
Copy link
Member

aledbf commented Jul 13, 2017

@jcmoraisjr are you using slack? (k8s)

@jcmoraisjr
Copy link
Contributor Author

Yes. jcmoraisjr

@jcmoraisjr
Copy link
Contributor Author

jcmoraisjr commented Jul 14, 2017

What about this one? Couldn't reproduce the failed test.

@jcmoraisjr jcmoraisjr closed this Jul 16, 2017
@jcmoraisjr jcmoraisjr deleted the jm-sort-backends branch July 16, 2017 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants