infra/gcp: clean stale removal code, misc prow cleanup #2076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that we've run the scripts, we no longer need the presence of one-shot functions, or bindings that have already been removed. Removed specifically: - ensure_removed_google_prow_bindings (release, staging) - removed_org_role bindings (organization) - k8s-infra-gcp-auditor running on aaa (main)
use empower_gke_for_serviceaccount instead
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
wg/k8s-infra
approved
|
/lgtm |
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
To run:
|
|
Ran everything I needed to run to confirm that changes were a no-op. |
|
Related to : #516 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that things have been removed, remove the stale data/code
Consolidate everything to use
empower_gke_for_service_accountinstead ofempower_ksa_to_svcacctAdd a
PROW_JOB_NAMESPACEconstant tolib.shand replace hardcodes oftest-podsI think we're close to removing the remaining k8s-prow and k8s-prow-builds bindings but I need to move on to other stuff, will save that for a later PR