-
Notifications
You must be signed in to change notification settings - Fork 813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
infra/gcp/prow: Add e2e project for sig-scalability #2195
infra/gcp/prow: Add e2e project for sig-scalability #2195
Conversation
/assign @spiffxp |
6510918
to
7aa2e47
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I left my comment at pending so in case it doesn't come through: I would rather start with just the one project instead of provisioning five projects. That's five times more capacity than we have provisioned today. I'm in no rush to spend even more than we do today without concrete justification
# e2e projects with 5000 nodes for scalability jobs | ||
E2E_SCALE_5K_PROJECTS=() | ||
for i in $(seq 1 5); do | ||
E2E_SCALE_5K_PROJECTS+=("$(printf "k8s-infra-e2e-boskos-scale-5k-%02i" "$i")") | ||
done | ||
readonly E2E_SCALE_5K_PROJECTS | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is still too many IMO, I'd rather keep us to just the one (k8s-infra-e2e-scale-5k-project
) until there's a proven need for more than one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@spiffxp Somehow I missed your comment. 😞
PR updated.
7aa2e47
to
db4f84d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nit otherwise lgtm
Add e2e project for sig-scalability prowjobs that need 5K nodes. Initial suggestion : kubernetes/test-infra#22430 (review) Signed-off-by: Arnaud Meukam <ameukam@gmail.com>
db4f84d
to
92fb97f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ameukam, spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I'll take care of deploying |
Opened #2223 to fix, re-running... |
Deployed
|
Ref #2241 |
Add e2e projects for sig-scalability prowjobs that need 5K nodes.
Initial suggestion : kubernetes/test-infra#22430 (review)
Signed-off-by: Arnaud Meukam ameukam@gmail.com