-
Notifications
You must be signed in to change notification settings - Fork 813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixup scalability test logs #2239
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What the bucket looks like # $ gsutil iam get gs://sig-scalability-logs | yq -y
bindings:
- members:
- projectEditor:kubernetes-jenkins
- projectOwner:kubernetes-jenkins
role: roles/storage.legacyBucketOwner
- members:
- allUsers
role: roles/storage.legacyBucketReader
- members:
- serviceAccount:prow-build@k8s-infra-prow-build.iam.gserviceaccount.com
role: roles/storage.objectAdmin
etag: CAU How it's used in kubernetes/test-infra
So, thoughts:
|
I've deployed the changes in adca451 via |
/hold But I would rather see a PR to change to |
The bucket is empty and unused for the moment. It can be deleted and recreated in kubernetes-public. I'll take care of that in a followup PR. |
/lgtm |
Ref: kubernetes#2239 (comment). Signed-off-by: Arnaud Meukam <ameukam@gmail.com>
Part of #1310 (comment)
Followup to #2229
Started by noticing an improper binding in an audit PR #2234 (comment)
Then I noticed we were using a terraform resource that overwrites existing policy, so I added back my best guess for existing policy
Now I'm beginning to think this bucket should actually go live over in kubernetes-public since this is effectively another results bucket