Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create infrastructure for kubebuilder artifacts #4586

Merged
merged 3 commits into from
Jan 18, 2023

Conversation

rikatz
Copy link
Contributor

@rikatz rikatz commented Dec 30, 2022

Per #2647

kubebuilder folks need to regain access to old GCP projects, and while discussing with @camilamacedo86 how to achieve this, I've figured out this could be an opportunity for now on to migrate new artifacts to community owned infrastructure.

This PR is split on 4 commits and:

  • Creates the new google group for kubebuilder staging under sig-apimachinery
  • Creates the required project for kubebuilder staging
  • Creates the required image promotion manifests after cloudbuild prow job for kube-rbac-proxy runs
  • Creates the required filestore promotion manifest after cloudbuild prowjob for kubebuilder-tools runs DROPPED THIS COMMIT AS IT NEEDS PREVIOUS STUFF TO BE DONE

After this PR gets merged, there are still some follow up actions:

  • Add two prowjobs post submit for the specific kubebuilder repo branches, to run cloudbuild for kube-rbac-proxy and tools and respectively send the artifacts to the right staging places
  • Check/fix cloudbuild yaml files on kubebuilder to use Kubernetes cloudbuild required patterns
  • Update kubebuilder release process, to reflect the fact that after cloud build jobs runs, one should go to k8s.io repo, on the image promotion manifests, and request the promotion of the artifacts to the prod buckets/filestore/gcr

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/access Define who has access to what via IAM bindings, role bindings, policy, etc. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/groups Google Groups management, code in groups/ area/infra Infrastructure management, infrastructure design, code in infra/ labels Dec 30, 2022
@k8s-ci-robot k8s-ci-robot added area/k8s.gcr.io Code in k8s.gcr.io/ size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. labels Dec 30, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Dec 30, 2022
@k8s-ci-robot
Copy link
Contributor

@rikatz: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-k8sio-file-promo 219cde7 link true /test pull-k8sio-file-promo

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dims
Copy link
Member

dims commented Jan 18, 2023

/approve
/lgtm

@rikatz landing this now, please ping me back if any of the resources are not created in say an hour or so after this merges.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, rikatz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 18, 2023
@k8s-ci-robot k8s-ci-robot merged commit c86223e into kubernetes:main Jan 18, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.27 milestone Jan 18, 2023
@rikatz
Copy link
Contributor Author

rikatz commented Feb 15, 2023

Just saw this @dims thanks! I will add myself to the groups to check if everything is working fine, and I've reached @camilamacedo86 to help on this migration. If she and kubebuilder team are ok with this,I will help on migration then remove myself.

Thanks!

Comment on lines +4 to +7
approvers:
- pwittrock
- camilamacedo86
- varshaprasad96
Copy link

@camilamacedo86 camilamacedo86 Jul 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need add here @vincepri and @sbueringer (if they agree with)

This one will probably only used for we build and promote : kubernetes-sigs/kubebuilder-release-tools#60 so far

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/access Define who has access to what via IAM bindings, role bindings, policy, etc. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/groups Google Groups management, code in groups/ area/infra Infrastructure management, infrastructure design, code in infra/ area/k8s.gcr.io Code in k8s.gcr.io/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants