-
Notifications
You must be signed in to change notification settings - Fork 822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ExternalDNS: promote v0.5.18 #540
Conversation
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: linki The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
@linki: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@linki Happy to LGTM this, but in general can you provide some guidelines for releasing ExternalDNS in the ExternalDNS repo? |
/lgtm |
Thanks @Raffo. You're right, we should document that once it's working. I created an issue: kubernetes-sigs/external-dns#1371 |
To answer the above question: The image doesn't need to be tagged in staging. The logic of the YAML in here is: take the image with the sha256, mirror it to production, and tag it with the tag. |
This promotes
v0.5.18
from staging to production.I wonder if the docker image described by the
sha256
must already be taggedv0.5.18
in the staging registry or if that is taken care of when promoting it.Background: We didn't manage to push to the staging repository with our desired tags yet. They still are prefixed with the date, see here.
Anyway, we figured it might be worth a try 😃