Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExternalDNS: promote v0.5.18 #540

Merged
merged 1 commit into from
Jan 15, 2020

Conversation

linki
Copy link
Member

@linki linki commented Jan 15, 2020

This promotes v0.5.18 from staging to production.

I wonder if the docker image described by the sha256 must already be tagged v0.5.18 in the staging registry or if that is taken care of when promoting it.

Background: We didn't manage to push to the staging repository with our desired tags yet. They still are prefixed with the date, see here.

Anyway, we figured it might be worth a try 😃

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. wg/k8s-infra labels Jan 15, 2020
@linki
Copy link
Member Author

linki commented Jan 15, 2020

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: linki

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 15, 2020
@linki
Copy link
Member Author

linki commented Jan 15, 2020

/lgtm

@k8s-ci-robot
Copy link
Contributor

@linki: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Raffo
Copy link
Contributor

Raffo commented Jan 15, 2020

@linki Happy to LGTM this, but in general can you provide some guidelines for releasing ExternalDNS in the ExternalDNS repo?

@Raffo
Copy link
Contributor

Raffo commented Jan 15, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 15, 2020
@k8s-ci-robot k8s-ci-robot merged commit 2645547 into kubernetes:master Jan 15, 2020
@linki linki deleted the external-dns-v0.5.18 branch January 15, 2020 11:02
@linki
Copy link
Member Author

linki commented Jan 15, 2020

Thanks @Raffo. You're right, we should document that once it's working. I created an issue: kubernetes-sigs/external-dns#1371

@linki
Copy link
Member Author

linki commented Jan 15, 2020

To answer the above question: The image doesn't need to be tagged in staging. The logic of the YAML in here is: take the image with the sha256, mirror it to production, and tag it with the tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants