Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

descheduler: promote v0.18.0 container image #888

Merged
merged 2 commits into from
May 22, 2020
Merged

descheduler: promote v0.18.0 container image #888

merged 2 commits into from
May 22, 2020

Conversation

seanmalloy
Copy link
Member

@seanmalloy
descheduler: promote v0.18.0 container image
12a2943 
Descheduler v0.18.0 was released on May 20, 2020. This pull request
promotes the descheduler v0.18.0 container image to the production
container registry.

https://github.com/kubernetes-sigs/descheduler/releases/tag/v0.18.0
@seanmalloy
Add Mike Dame As Approver For Descheduler Container Images
cc87801
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 21, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @seanmalloy. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects labels May 21, 2020
@seanmalloy seanmalloy mentioned this pull request May 21, 2020
Closed
4 tasks
@seanmalloy
Copy link
Member Author

/assign @damemi @aveshagarwal @ravisantoshgudimetla

You can pull down the container image using the below command if you want to do a smoke test prior to merging this.

 docker pull gcr.io/k8s-staging-descheduler/descheduler:v20200521-v0.18.0

damemi
damemi approved these changes May 21, 2020
View reviewed changes
Copy link
Contributor

@damemi damemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 21, 2020
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 21, 2020
@seanmalloy
Copy link
Member Author

@aveshagarwal and @ravisantoshgudimetla I was able to successfully smoke test this image on my laptop using a kind cluster. Please review when you have some time.

@aveshagarwal
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aveshagarwal, damemi, seanmalloy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 22, 2020
@k8s-ci-robot k8s-ci-robot merged commit b4bec26 into kubernetes:master May 22, 2020
@seanmalloy seanmalloy deleted the descheduler-v0.18.0 branch May 22, 2020 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damemi damemi damemi approved these changes

@aveshagarwal aveshagarwal Awaiting requested review from aveshagarwal

@dims dims Awaiting requested review from dims

Assignees

@damemi damemi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@seanmalloy @k8s-ci-robot @aveshagarwal @damemi