Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix daemonset creation (add selector) #1512

Merged
merged 1 commit into from
Aug 23, 2022
Merged

fix daemonset creation (add selector) #1512

merged 1 commit into from
Aug 23, 2022

Conversation

realgam3
Copy link
Contributor

To fix daemonset creation, add a selector

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jun 30, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: realgam3 / name: Tomer Zait (06bb4f5)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jun 30, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @realgam3!

It looks like this is your first PR to kubernetes/kompose 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kompose has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 30, 2022
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jun 30, 2022
@realgam3
Copy link
Contributor Author

realgam3 commented Jun 30, 2022 •
edited
Loading

A daemonset created with selector=null causes an error when applied:
error: error validating "test-daemonset.yaml": error validating data: ValidationError(DaemonSet.spec): missing required field "selector" in io.k8s.api.apps.v1.DaemonSetSpec; if you choose to ignore these errors, turn validation off with --validate=false

@realgam3
Copy link
Contributor Author

realgam3 commented Jul 3, 2022 •
edited
Loading

/assign @hangyan

@realgam3
Copy link
Contributor Author

realgam3 commented Jul 7, 2022

Hi @kadel and @surajssd,
Can you review this pull request?
It fix an error I encounter lately

@kadel
Copy link
Member

kadel commented Aug 23, 2022

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 23, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kadel, realgam3

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 23, 2022
@kadel
Copy link
Member

kadel commented Aug 23, 2022

/retest

@kadel
Copy link
Member

kadel commented Aug 23, 2022

/refresh

@k8s-ci-robot k8s-ci-robot merged commit 9055f21 into kubernetes:master Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kadel kadel Awaiting requested review from kadel

@surajssd surajssd Awaiting requested review from surajssd

Assignees

@kadel kadel

@hangyan hangyan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@realgam3 @k8s-ci-robot @kadel @hangyan