-
Notifications
You must be signed in to change notification settings - Fork 763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Labels for CronJob https://github.com/kubernetes/kompose/issues/1795 #1806
Conversation
@AhmedGrati @cdrage I hope it's ok with you... |
Fine by me! |
I'll go through the code once all the tests have pass & I have a bit of time tonight :) |
Thank you ❤️ |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cdrage, realgam3 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Approving and LGTM since this has been throughly reviewed a few times! Thanks for the awesome new feature! I'll push a new release this week so this is out :) |
Thank you! |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Add CronJob Labels:
kompose.controller.type
: cronjobkompose.cronjob.schedule
: "5 4 * * *"kompose.cronjob.concurrency_policy
: (Allow|Forbid|Replace)Which issue(s) this PR fixes:
Feature #1795
Special notes for your reviewer: