Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup README.md #1823

Conversation

utkarsh-singh1
Copy link
Contributor

…able in old versions

What type of PR is this?

/kind documentation

What this PR does / why we need it:

Installation instruction for linux, it can Also be installed with brew or using go install method.

Which issue(s) this PR fixes:

Fixes # 1822

Special notes for your reviewer:

…able in old versions

Signed-off-by: utkarsh-singh1 <utkarsh.singh1@india.nec.com>
@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 12, 2024
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 12, 2024
@utkarsh-singh1
Copy link
Contributor Author

As older version of Kompose binary still in Repos of NixOS and OpenSuse tumbleweed, will require further assistance on should we remove their installation instruction or there will be new version available on those repos.

@utkarsh-singh1
Copy link
Contributor Author

utkarsh-singh1 commented Feb 12, 2024

Signed-off-by: utkarsh-singh1 <utkarsh.singh1@india.nec.com>
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 12, 2024
@cdrage
Copy link
Member

cdrage commented Feb 12, 2024

/approve

@cdrage
Copy link
Member

cdrage commented Feb 12, 2024

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cdrage, utkarsh-singh1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 12, 2024
@k8s-ci-robot k8s-ci-robot merged commit 4211798 into kubernetes:main Feb 12, 2024
10 checks passed
@utkarsh-singh1
Copy link
Contributor Author

Thanks @cdrage, for the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants