-
Notifications
You must be signed in to change notification settings - Fork 763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update user guide #1882
docs: update user guide #1882
Conversation
7653bd4
to
92f03ec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @cdrage this looks much cleaner and more concise. Left some comments below.
@TessaIO thank you! Updated it and ready for another review. |
Failing because #1886 needs to go in |
#### What type of PR is this? <!-- Add one of the following kinds: /kind bug /kind cleanup /kind feature --> /kind documentation #### What this PR does / why we need it: Updates the user guide completely revamp it / describe each label. #### Which issue(s) this PR fixes: <!-- *Automatically closes linked issue when PR is merged. Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`. --> Closes kubernetes#1584 Closes kubernetes#1577 #### Special notes for your reviewer: Signed-off-by: Charlie Drage <charlie@charliedrage.com> Please check the docs examples / each label that it's okay!
Co-authored-by: TessaIO <ahmedgrati1999@gmail.com>
Co-authored-by: TessaIO <ahmedgrati1999@gmail.com>
Co-authored-by: TessaIO <ahmedgrati1999@gmail.com>
Signed-off-by: Charlie Drage <charlie@charliedrage.com>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cdrage, TessaIO The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
docs: update user guide
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Updates the user guide completely revamp it / describe each label.
Which issue(s) this PR fixes:
Closes #1584
Closes #1577
Closes #1576
Special notes for your reviewer:
Signed-off-by: Charlie Drage charlie@charliedrage.com
Please check the docs examples / each label that it's okay!