Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update user guide #1882

Merged
merged 5 commits into from
Jun 2, 2024
Merged

docs: update user guide #1882

merged 5 commits into from
Jun 2, 2024

Conversation

cdrage
Copy link
Member

@cdrage cdrage commented May 29, 2024

docs: update user guide

What type of PR is this?

/kind documentation

What this PR does / why we need it:

Updates the user guide completely revamp it / describe each label.

Which issue(s) this PR fixes:

Closes #1584
Closes #1577
Closes #1576

Special notes for your reviewer:

Signed-off-by: Charlie Drage charlie@charliedrage.com

Please check the docs examples / each label that it's okay!

@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 29, 2024
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 29, 2024
@cdrage cdrage force-pushed the update-user-guide branch 2 times, most recently from 7653bd4 to 92f03ec Compare May 29, 2024 21:02
docs/user-guide.md Outdated Show resolved Hide resolved
docs/user-guide.md Outdated Show resolved Hide resolved
docs/user-guide.md Outdated Show resolved Hide resolved
Copy link
Member

@TessaIO TessaIO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cdrage this looks much cleaner and more concise. Left some comments below.

@cdrage
Copy link
Member Author

cdrage commented May 30, 2024

@TessaIO thank you! Updated it and ready for another review.

@cdrage
Copy link
Member Author

cdrage commented May 30, 2024

Failing because #1886 needs to go in

cdrage and others added 5 commits May 30, 2024 11:54
#### What type of PR is this?

<!--
Add one of the following kinds:
/kind bug
/kind cleanup
/kind feature
-->
/kind documentation

#### What this PR does / why we need it:

Updates the user guide completely revamp it / describe each label.

#### Which issue(s) this PR fixes:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
-->

Closes kubernetes#1584
Closes kubernetes#1577

#### Special notes for your reviewer:
Signed-off-by: Charlie Drage <charlie@charliedrage.com>

Please check the docs examples / each label that it's okay!
Co-authored-by: TessaIO <ahmedgrati1999@gmail.com>
Co-authored-by: TessaIO <ahmedgrati1999@gmail.com>
Co-authored-by: TessaIO <ahmedgrati1999@gmail.com>
Signed-off-by: Charlie Drage <charlie@charliedrage.com>
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cdrage, TessaIO

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@TessaIO TessaIO merged commit 6a5c646 into kubernetes:main Jun 2, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
3 participants