-
Notifications
You must be signed in to change notification settings - Fork 763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Push image without authentication #913
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
6a22751
to
94d1608
Compare
@coodix does this actually work on MacOS? |
@cdrage , yes, checked with local private repository which was set up it with: And pushed image to localhost:5000. |
pkg/utils/docker/push.go
Outdated
log.Warn(errors.Wrap(err, "Unable to retrieve .docker/config.json authentication details. Check that 'docker login' works successfully on the command line.")) | ||
} | ||
|
||
if credentials == nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mind adding a comment here saying TODO: refactor as well as detail the error (add the fsouza/dockerclient-go) issue? Otherwise, this code LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The thing is that it would be nice to have this approach (try push without authentication) cause when you use local private repo it doesn't actually require login (via docker login command) there before accessing it.
If you thing kompose should always expect available credentials in config.json I can add the comment "TODO: refactor as well as dockerclient-go starts retrieve credentials from osxkeychain (add the fsouza/dockerclient-go) issue".
What do you think?
94d1608
to
60f1e57
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution, this LGTM 👍
For fixing issue #911