Skip to content

Commit

Permalink
Merge pull request #7555 from justinsb/make_sha256_hash_messages_less…
Browse files Browse the repository at this point in the history
…_alarming

Log more sensibly when we can't get sha256
  • Loading branch information
k8s-ci-robot authored Sep 10, 2019
2 parents 0ee8434 + cc20210 commit e0f792a
Showing 1 changed file with 6 additions and 1 deletion.
7 changes: 6 additions & 1 deletion pkg/assets/builder.go
Original file line number Diff line number Diff line change
Expand Up @@ -306,7 +306,12 @@ func (a *AssetBuilder) findHash(file *FileAsset) (*hashing.Hash, error) {
hashURL := u.String() + ext
b, err := vfs.Context.ReadFile(hashURL, vfs.WithBackoff(backoff))
if err != nil {
klog.Infof("error reading hash file %q: %v", hashURL, err)
// Try to log without being too alarming - issue #7550
if ext == ".sha256" {
klog.V(2).Infof("unable to read new sha256 hash file (is this an older/unsupported kubernetes release?) %q: %v", hashURL, err)
} else {
klog.V(2).Infof("unable to read hash file %q: %v", hashURL, err)
}
continue
}
hashString := strings.TrimSpace(string(b))
Expand Down

0 comments on commit e0f792a

Please sign in to comment.